| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | David Rowley <dgrowleyml(at)gmail(dot)com> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Compilation issues for HASH_STATISTICS and HASH_DEBUG options |
| Date: | 2025-08-18 13:34:34 |
| Message-ID: | 344325.1755524074@sss.pgh.pa.us |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
David Rowley <dgrowleyml(at)gmail(dot)com> writes:
> I've purposefully left references to HASH_DEBUG in the "Original
> comments" section near the top of dynahash.c. That comment also
> references function names that no longer exist.
Hm, there is actually no part of that comment para that is accurate
anymore, so I cannot imagine a reason for leaving it alone. People
who want to do archaeology can consult the git history. How about
reducing the para to
* HASH_STATISTICS causes some usage statistics to be maintained,
* which can be logged by calling hash_stats().
LGTM otherwise.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dominique Devienne | 2025-08-18 13:40:28 | Re: Identifying function-lookup failures due to argument name mismatches |
| Previous Message | torikoshia | 2025-08-18 13:32:09 | Re: Enhancing Memory Context Statistics Reporting |