Re: BUG #19086: pg_dump --data-only selects and do not uses index definitions for the dumped tables.

On Thu, 16 Oct 2025 at 12:36, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> (Hmm ... but on the third hand, if we only need one of the
> two strings, couldn't we mechanize that by wrapping the
> pg_get_indexdef call in CASE WHEN c.contype IS DISTINCT FROM 'x'
> ?)

Unless I'm mistaken, it looks like the "indexdef" field is used only
when there's no corresponding constraint with contype 'p,', 'u' or
'x'. Wouldn't it be more like:

CASE WHEN c.conrelid IS NULL THEN
pg_catalog.pg_get_indexdef(i.indexrelid) ELSE '' END AS indexdef

which saves calling the function a bit more often than what you said... ?

The code I'm looking at is:

/* Plain secondary index */
indxinfo[j].indexconstraint = 0;

and "if (!is_constraint)" in dumpIndex().

David