| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | David Rowley <dgrowleyml(at)gmail(dot)com> |
| Cc: | Nathan Bossart <nathandbossart(at)gmail(dot)com>, andrewbille(at)gmail(dot)com, pgsql-bugs(at)lists(dot)postgresql(dot)org |
| Subject: | Re: BUG #19086: pg_dump --data-only selects and do not uses index definitions for the dumped tables. |
| Date: | 2025-10-16 00:45:47 |
| Message-ID: | 1342348.1760575547@sss.pgh.pa.us |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
David Rowley <dgrowleyml(at)gmail(dot)com> writes:
> On Thu, 16 Oct 2025 at 12:36, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> (Hmm ... but on the third hand, if we only need one of the
>> two strings, couldn't we mechanize that by wrapping the
>> pg_get_indexdef call in CASE WHEN c.contype IS DISTINCT FROM 'x'
>> ?)
> Unless I'm mistaken, it looks like the "indexdef" field is used only
> when there's no corresponding constraint with contype 'p,', 'u' or
> 'x'.
Ah. I hadn't researched that, but it makes sense.
> Wouldn't it be more like:
> CASE WHEN c.conrelid IS NULL THEN
> pg_catalog.pg_get_indexdef(i.indexrelid) ELSE '' END AS indexdef
I'd leave out the ELSE so that you get a null if the function
isn't run, but yeah. (The places saving these query results would
need PQgetisnull tests, too.)
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Yuri Zamyatin | 2025-10-16 01:10:43 | Re: BUG #19078: Segfaults in tts_minimal_store_tuple() following pg_upgrade |
| Previous Message | David Rowley | 2025-10-16 00:35:24 | Re: BUG #19086: pg_dump --data-only selects and do not uses index definitions for the dumped tables. |