Re: Keep elog(ERROR) and ereport(ERROR) calls in the cold path

From: David Rowley <dgrowleyml(at)gmail(dot)com>
To: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
Cc: Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Keep elog(ERROR) and ereport(ERROR) calls in the cold path
Date: 2020-09-22 20:42:33
Message-ID: CAApHDvo2N31OoA7KzF-t9w12TYVQkvGhK6juvO=6vyovQNoyPg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, 22 Sep 2020 at 19:08, David Rowley <dgrowleyml(at)gmail(dot)com> wrote:
> I ran another scale=5 TPCH benchmark on v4 against f859c2ffa using gcc
> 9.3. I'm unable to see any gains with this, however, the results were
> pretty noisy. I only ran pgbench for 60 seconds per query. I'll likely
> need to run that a bit longer. I'll do that tonight.

I've attached the results of a TPCH scale=5 run master (f859c2ffa) vs
master + elog_ereport_attribute_cold_v4.patch

It does not look great. The patched version seems to have done about
1.17% less work than master did.

David

Attachment Content-Type Size
tpch_scale5_elog_ereport_cold_v4_vs_master_10min.ods application/vnd.oasis.opendocument.spreadsheet 19.5 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message tsunakawa.takay@fujitsu.com 2020-09-22 20:42:50 RE: Transactions involving multiple postgres foreign servers, take 2
Previous Message Peter Geoghegan 2020-09-22 20:17:59 Re: new heapcheck contrib module