Re: Is tuplesort meant to support bounded datum sorts?

From: David Rowley <dgrowleyml(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Ronan Dunklau <ronan(dot)dunklau(at)aiven(dot)io>
Subject: Re: Is tuplesort meant to support bounded datum sorts?
Date: 2021-07-13 01:36:21
Message-ID: CAApHDvo0Z=EMi=xmEf7e0mtcQr_pAjn7V99+ANH=d2_7=xXbEA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, 13 Jul 2021 at 04:10, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>
> David Rowley <dgrowleyml(at)gmail(dot)com> writes:
> > It looks like this has likely never come up before because the only
> > time we use tuplesort_set_bound() is in nodeSort.c and
> > nodeIncrementalSort.c, none of those currently use datum sorts.
> > However, I'm thinking this is still a bug that should be fixed
> > separately from Ronan's main patch.
>
> Yeah, I think you're right. The comment seems a little confused
> though. Maybe there's no need for it at all --- there's equivalent
> code in e.g. writetup_datum that has no comment.

Thanks for looking at this. I've pushed a fix and backpatched.

David

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2021-07-13 01:53:12 Re: Introduce pg_receivewal gzip compression tests
Previous Message Thomas Munro 2021-07-13 01:25:50 Re: O_DIRECT on macOS