Re: Is tuplesort meant to support bounded datum sorts?

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: David Rowley <dgrowleyml(at)gmail(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Ronan Dunklau <ronan(dot)dunklau(at)aiven(dot)io>
Subject: Re: Is tuplesort meant to support bounded datum sorts?
Date: 2021-07-12 16:10:24
Message-ID: 2981082.1626106224@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

David Rowley <dgrowleyml(at)gmail(dot)com> writes:
> It looks like this has likely never come up before because the only
> time we use tuplesort_set_bound() is in nodeSort.c and
> nodeIncrementalSort.c, none of those currently use datum sorts.
> However, I'm thinking this is still a bug that should be fixed
> separately from Ronan's main patch.

Yeah, I think you're right. The comment seems a little confused
though. Maybe there's no need for it at all --- there's equivalent
code in e.g. writetup_datum that has no comment.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message vignesh C 2021-07-12 16:11:51 Re: proposal - psql - use pager for \watch command
Previous Message Bharath Rupireddy 2021-07-12 15:56:19 Use WaitLatch for {pre, post}_auth_delay instead of pg_usleep