| From: | Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Jeff Davis <pgsql(at)j-davis(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Ibrar Ahmed <ibrar(dot)ahmad(at)gmail(dot)com>, Amit Khandekar <amitdkhan(dot)pg(at)gmail(dot)com>, fabriziomello(at)gmail(dot)com, tushar <tushar(dot)ahuja(at)enterprisedb(dot)com>, Rahila Syed <rahila(dot)syed(at)2ndquadrant(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Minimal logical decoding on standbys |
| Date: | 2023-04-08 06:52:27 |
| Message-ID: | CAAc5aFM6WXedc8Skmr3v=acPR_JCDuuPTJ2ptuwFX1NxAioqHA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
New wording works for me, thanks!
Bertrand
Le sam. 8 avr. 2023, 08:26, Andres Freund <andres(at)anarazel(dot)de> a écrit :
> Hi,
>
> On 2023-04-07 11:12:26 -0700, Andres Freund wrote:
> > + <row>
> > + <entry role="catalog_table_entry"><para role="column_definition">
> > + <structfield>confl_active_logicalslot</structfield>
> <type>bigint</type>
> > + </para>
> > + <para>
> > + Number of active logical slots in this database that have been
> > + invalidated because they conflict with recovery (note that
> inactive ones
> > + are also invalidated but do not increment this counter)
> > + </para></entry>
> > + </row>
> > </tbody>
> > </tgroup>
> > </table>
>
> This seems wrong to me. The counter is not for invalidated slots, it's for
> recovery conflict interrupts. If phrased that way, the parenthetical would
> be
> unnecessary.
>
> I think something like
> Number of uses of logical slots in this database that have been
> canceled due to old snapshots or a too low <xref
> linkend="guc-wal-level"/>
> on the primary
>
> would work and fit with the documentation of the other fields? Reads a bit
> stilted, but so do several of the other fields...
>
> Greetings,
>
> Andres Freund
>
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Daniel Gustafsson | 2023-04-08 07:53:58 | Re: Making background psql nicer to use in tap tests |
| Previous Message | Andres Freund | 2023-04-08 06:26:26 | Re: Minimal logical decoding on standbys |