| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, "Drouvot, Bertrand" <bertranddrouvot(dot)pg(at)gmail(dot)com> |
| Cc: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Jeff Davis <pgsql(at)j-davis(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Ibrar Ahmed <ibrar(dot)ahmad(at)gmail(dot)com>, Amit Khandekar <amitdkhan(dot)pg(at)gmail(dot)com>, fabriziomello(at)gmail(dot)com, tushar <tushar(dot)ahuja(at)enterprisedb(dot)com>, Rahila Syed <rahila(dot)syed(at)2ndquadrant(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Minimal logical decoding on standbys |
| Date: | 2023-04-08 06:26:26 |
| Message-ID: | 20230408062626.pklygrtdfgzpujhx@awork3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On 2023-04-07 11:12:26 -0700, Andres Freund wrote:
> + <row>
> + <entry role="catalog_table_entry"><para role="column_definition">
> + <structfield>confl_active_logicalslot</structfield> <type>bigint</type>
> + </para>
> + <para>
> + Number of active logical slots in this database that have been
> + invalidated because they conflict with recovery (note that inactive ones
> + are also invalidated but do not increment this counter)
> + </para></entry>
> + </row>
> </tbody>
> </tgroup>
> </table>
This seems wrong to me. The counter is not for invalidated slots, it's for
recovery conflict interrupts. If phrased that way, the parenthetical would be
unnecessary.
I think something like
Number of uses of logical slots in this database that have been
canceled due to old snapshots or a too low <xref linkend="guc-wal-level"/>
on the primary
would work and fit with the documentation of the other fields? Reads a bit
stilted, but so do several of the other fields...
Greetings,
Andres Freund
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bertrand Drouvot | 2023-04-08 06:52:27 | Re: Minimal logical decoding on standbys |
| Previous Message | Andres Freund | 2023-04-08 06:04:08 | Re: Direct I/O |