| From: | Melanie Plageman <melanieplageman(at)gmail(dot)com> |
|---|---|
| To: | vignesh C <vignesh21(at)gmail(dot)com> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com> |
| Subject: | Re: Confine vacuum skip logic to lazy_scan_skip |
| Date: | 2024-02-27 19:47:03 |
| Message-ID: | CAAKRu_bQgf4e9OveCQX++zTEJLKbZbqLeapA7SNkNuMjxcCO1w@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Jan 29, 2024 at 8:18 PM Melanie Plageman
<melanieplageman(at)gmail(dot)com> wrote:
>
> On Fri, Jan 26, 2024 at 8:28 AM vignesh C <vignesh21(at)gmail(dot)com> wrote:
> >
> > CFBot shows that the patch does not apply anymore as in [1]:
> > === applying patch
> > ./v3-0002-Add-lazy_scan_skip-unskippable-state-to-LVRelStat.patch
> > patching file src/backend/access/heap/vacuumlazy.c
> > ...
> > Hunk #10 FAILED at 1042.
> > Hunk #11 FAILED at 1121.
> > Hunk #12 FAILED at 1132.
> > Hunk #13 FAILED at 1161.
> > Hunk #14 FAILED at 1172.
> > Hunk #15 FAILED at 1194.
> > ...
> > 6 out of 21 hunks FAILED -- saving rejects to file
> > src/backend/access/heap/vacuumlazy.c.rej
> >
> > Please post an updated version for the same.
> >
> > [1] - http://cfbot.cputube.org/patch_46_4755.log
>
> Fixed in attached rebased v4
In light of Thomas' update to the streaming read API [1], I have
rebased and updated this patch set.
The attached v5 has some simplifications when compared to v4 but takes
largely the same approach.
0001-0004 are refactoring
0005 is the streaming read code not yet in master
0006 is the vacuum streaming read user for vacuum's first pass
0007 is the vacuum streaming read user for vacuum's second pass
- Melanie
| Attachment | Content-Type | Size |
|---|---|---|
| v5-0004-Remove-unneeded-vacuum_delay_point-from-heap_vac_.patch | text/x-patch | 1.0 KB |
| v5-0001-lazy_scan_skip-remove-unneeded-local-var-nskippab.patch | text/x-patch | 1.7 KB |
| v5-0003-Confine-vacuum-skip-logic-to-lazy_scan_skip.patch | text/x-patch | 14.0 KB |
| v5-0005-Streaming-Read-API.patch | text/x-patch | 56.9 KB |
| v5-0002-Add-lazy_scan_skip-unskippable-state-to-LVRelStat.patch | text/x-patch | 15.8 KB |
| v5-0006-Vacuum-first-pass-uses-Streaming-Read-interface.patch | text/x-patch | 8.3 KB |
| v5-0007-Vacuum-second-pass-uses-Streaming-Read-interface.patch | text/x-patch | 8.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alexander Korotkov | 2024-02-27 20:03:33 | Re: Bytea PL/Perl transform |
| Previous Message | David Zhang | 2024-02-27 19:38:37 | Wrong description in server_ca.config and client_ca.config |