| From: | Melanie Plageman <melanieplageman(at)gmail(dot)com> |
|---|---|
| To: | Jeff Davis <pgsql(at)j-davis(dot)com> |
| Cc: | Dilip Kumar <dilipbalaut(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Andres Freund <andres(at)anarazel(dot)de> |
| Subject: | Re: Incorrect logic in XLogNeedsFlush() |
| Date: | 2025-09-10 15:12:11 |
| Message-ID: | CAAKRu_awiqADBD5403ptbsr6gy8-Z2Qyrc3u6wN6vf70syzjLQ@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Sep 9, 2025 at 9:50 PM Jeff Davis <pgsql(at)j-davis(dot)com> wrote:
>
> On Tue, 2025-09-09 at 16:29 -0400, Melanie Plageman wrote:
>
> > Though, it seems like LocalMinRecoveryPoint must be getting
> > incorrectly set elsewhere, otherwise this would have guarded us from
> > examining the control file:
>
> I am confused about whether we are discussing "incorrect" or "invalid".
I meant incorrect as in when it was not supposed to be -- not InvalidXLogRecPtr.
But, I've realized I misspoke -- because InRecovery is only true in
the startup process, so
if (XLogRecPtrIsInvalid(LocalMinRecoveryPoint) && InRecovery)
is false for checkpointer.
- Melanie
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Melanie Plageman | 2025-09-10 15:12:37 | Re: Incorrect logic in XLogNeedsFlush() |
| Previous Message | Corey Huinker | 2025-09-10 15:11:09 | Re: someone else to do the list of acknowledgments |