| From: | Jeff Davis <pgsql(at)j-davis(dot)com> |
|---|---|
| To: | Melanie Plageman <melanieplageman(at)gmail(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Andres Freund <andres(at)anarazel(dot)de> |
| Subject: | Re: Incorrect logic in XLogNeedsFlush() |
| Date: | 2025-09-10 01:50:37 |
| Message-ID: | 945b985ae22bfe9e88be029a3f4efd13c918e708.camel@j-davis.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, 2025-09-09 at 16:29 -0400, Melanie Plageman wrote:
> On Wed, Sep 3, 2025 at 11:38 PM Dilip Kumar <dilipbalaut(at)gmail(dot)com>
> wrote:
> >
> > On Sat, Aug 30, 2025 at 4:16 AM Melanie Plageman
> > <melanieplageman(at)gmail(dot)com> wrote:
> >
> > > Why is it okay for other processes than the startup process to
> > > initialize LocalMinRecoveryPoint from ControlFile-
> > > >minRecoveryPoint
> > > during crash recovery?
> >
> > During crash recovery we don't yet know the minRecoveryPoint until
> > we
> > replay all the WALs and once it is done it will be updated in the
> > ControlFile at PerformRecoveryXLogAction()-
> > >CreateEndOfRecoveryRecord().
...
>
> Though, it seems like LocalMinRecoveryPoint must be getting
> incorrectly set elsewhere, otherwise this would have guarded us from
> examining the control file:
I am confused about whether we are discussing "incorrect" or "invalid".
Regards,
Jeff Davis
> >
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Chao Li | 2025-09-10 02:26:42 | Mark ItemPointer arguments as const thoughoutly |
| Previous Message | Jeff Davis | 2025-09-10 01:28:55 | Re: Checkpointer write combining |