Re: Cleanup isolation specs from unused steps

From: Melanie Plageman <melanieplageman(at)gmail(dot)com>
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: Michael Paquier <michael(at)paquier(dot)xyz>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Cleanup isolation specs from unused steps
Date: 2019-08-22 17:20:48
Message-ID: CAAKRu_aZfa8pBKeLrGcrL42H9-VOU9m10ZFvWrbiiccsKQ7X0A@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Aug 21, 2019 at 12:16 PM Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
wrote:

> On 2019-Aug-21, Melanie Plageman wrote:
>
> > In Greenplum, we mainly add new tests to a separate isolation
> > framework (called isolation2) which uses a completely different
> > syntax. It doesn't use isolationtester at all. So, I haven't had a use
> > case to add long options to isolationtester yet :)
>
> Is that other framework somehow more capable?
>

So, there is some historical context as to why it is a separate test suite.
And some of the differences are specific to Greenplum -- e.g. needing to
connect
to a specific database in "utility mode" to do something.

However, the other differences are actually pretty handy and would be
applicable
to upstream as well.
We use a different syntax than the isolation framework and have some nice
features. Most notably, explicit control over blocking.

The syntax for what would be a "step" in isolation is like this:

[<#>[flag]:] <sql> | ! <shell scripts or command>

where # is the session number and flags include the following:

&: expect blocking behavior
>: running in background without blocking
<: join an existing session
q: quit the given session

See the script [1] for parsing the test cases for more details on the
syntax and
capabilities (it is in Python).

[1]
https://github.com/greenplum-db/gpdb/blob/master/src/test/isolation2/sql_isolation_testcase.py

--
Melanie Plageman

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2019-08-22 19:08:58 Preserving extension ownership in dump/restore/pg_upgrade
Previous Message Dilip Kumar 2019-08-22 17:15:55 Re: POC: Cleaning up orphaned files using undo logs