| From: | Melanie Plageman <melanieplageman(at)gmail(dot)com> |
|---|---|
| To: | Lukas Fittl <lukas(at)fittl(dot)com> |
| Cc: | Zsolt Parragi <zsolt(dot)parragi(at)percona(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org, Vaibhav Jain <jainva(at)google(dot)com>, pg(at)bowt(dot)ie, andres(at)anarazel(dot)de |
| Subject: | Re: [BUG / PATCH] PG19: VACUUM misestimates reltuples (often 0) after on-access VM setting |
| Date: | 2026-11-18 21:38:11 |
| Message-ID: | CAAKRu_aDPZy-7ymedg=jaShP4_JDmn1iZRz9FD_GcKFdScy9SQ@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Nov 18, 2026 at 12:21 PM Lukas Fittl <lukas(at)fittl(dot)com> wrote:
>
> On Wed, Nov 18, 2026 at 8:06 AM Melanie Plageman
> <melanieplageman(at)gmail(dot)com> wrote:
>
> > I've committed the fix and backpatched it. The question is whether we
> > want master to return NULL when there was not enough information to
> > make an estimate for approx_tuple_count.
>
> Personally I still think returning NULL is the better choice on master
> - its easy enough to update for a client program, and I think 0 is
> ambiguous (so we should try to get away from that ambiguity over
> time).
Cool. I'll commit the attached tomorrow then.
- Melanie
| Attachment | Content-Type | Size |
|---|---|---|
| v1-0001-Return-NULL-for-unknown-pgstattuple-estimate.patch | text/x-patch | 4.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | surya poondla | 2026-11-18 22:07:39 | Re: Partitioned index marked valid while a partition is pending detach |
| Previous Message | Tomás Senart | 2026-11-18 20:52:48 | Re: [PATCH v1] Avoid deforming unused trailing columns in COPY TO |