| From: | Lukas Fittl <lukas(at)fittl(dot)com> |
|---|---|
| To: | Melanie Plageman <melanieplageman(at)gmail(dot)com> |
| Cc: | Zsolt Parragi <zsolt(dot)parragi(at)percona(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org, Vaibhav Jain <jainva(at)google(dot)com>, pg(at)bowt(dot)ie, andres(at)anarazel(dot)de |
| Subject: | Re: [BUG / PATCH] PG19: VACUUM misestimates reltuples (often 0) after on-access VM setting |
| Date: | 2026-11-18 17:20:55 |
| Message-ID: | CAP53PkzhhC4yQtmBLGHz41-Bs3ZqtQdtYGjxMh_xcTK6Z7eU9Q@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Nov 18, 2026 at 8:06 AM Melanie Plageman
<melanieplageman(at)gmail(dot)com> wrote:
>
> On Sat, Nov 14, 2026 at 11:23 AM Melanie Plageman
> <melanieplageman(at)gmail(dot)com> wrote:
> >
> > I'll commit this specific patch after the 19 freeze is over to go out
> > with the next set of minors. Thanks again for the timely review and
> > apologies for not getting it out in time. I can then apply the change
> > to make it NULL on master afterward, assuming we think that's the
> > right thing to do.
>
> I've committed the fix and backpatched it. The question is whether we
> want master to return NULL when there was not enough information to
> make an estimate for approx_tuple_count.
Personally I still think returning NULL is the better choice on master
- its easy enough to update for a client program, and I think 0 is
ambiguous (so we should try to get away from that ambiguity over
time).
Thanks,
Lukas
--
Lukas Fittl
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bharath Rupireddy | 2026-11-18 17:29:49 | Re: Parallel vacuum: check XID wraparound failsafe between indexes |
| Previous Message | Alberto Piai | 2026-11-18 16:40:47 | Re: Adding a stored generated column without long-lived locks |