| From: | Melanie Plageman <melanieplageman(at)gmail(dot)com> |
|---|---|
| To: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Cc: | Tomáš Vondra <tv(at)fuzzy(dot)cz>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
| Subject: | Remove unneeded check for XLH_INSERT_ALL_FROZEN in heap_xlog_insert |
| Date: | 2025-06-24 17:41:44 |
| Message-ID: | CAAKRu_Zp4Pi-t51OFWm1YZ-cctDfBhHCMZ=Ex6PKxv0o8y2GvA@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
I noticed that 8e03eb92e9a forgot one line when reverting 39b66a91bd.
There is an extraneous check for XLH_INSERT_ALL_FROZEN_SET in
heap_xlog_insert() -- even though heap_insert() never freezes tuples.
It doesn't hurt anything, but I found it confusing, so I think it is
worth removing. I don't think it's worth backpatching, so I don't know
if that means that this commit shouldn't go in master until after we
branch.
- Melanie
| Attachment | Content-Type | Size |
|---|---|---|
| v1-0001-Remove-unused-check-in-heap_xlog_insert.patch | text/x-patch | 1.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Álvaro Herrera | 2025-06-24 17:45:15 | Re: queryId constant squashing does not support prepared statements |
| Previous Message | Nathan Bossart | 2025-06-24 16:47:58 | Re: pg_dump --with-* options |