On 6/24/25 19:41, Melanie Plageman wrote:
> Hi,
>
> I noticed that 8e03eb92e9a forgot one line when reverting 39b66a91bd.
> There is an extraneous check for XLH_INSERT_ALL_FROZEN_SET in
> heap_xlog_insert() -- even though heap_insert() never freezes tuples.
> It doesn't hurt anything, but I found it confusing, so I think it is
> worth removing. I don't think it's worth backpatching, so I don't know
> if that means that this commit shouldn't go in master until after we
> branch.
Thanks for noticing this. I'd probably be +0.5 to backpatch this, even
if it's ultimately harmless, just to keep the code not confusing.
regards
--
Tomas Vondra