| From: | Melanie Plageman <melanieplageman(at)gmail(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Alexander Lakhin <exclusion(at)gmail(dot)com>, Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org, Peter Geoghegan <pg(at)bowt(dot)ie>, Tomas Vondra <tv(at)fuzzy(dot)cz> |
| Subject: | Re: Don't synchronously wait for already-in-progress IO in read stream |
| Date: | 2026-03-31 18:25:49 |
| Message-ID: | CAAKRu_YGG5ABz5xbd1jqSNkAs1EAbFOFibuO6EULYWhy9MDwuw@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Mar 31, 2026 at 8:43 AM Andres Freund <andres(at)anarazel(dot)de> wrote:
>
> Looks good to me.
>
> Will you push?
I was going to push but then Bilal asked me off-list if there was some
reason not to set the members of ReadBuffersOperation outside of
assert builds. I agree with him that it seems like a future user of
StartReadBuffersImpl() could make this same mistake. Both of us
vaguely recall this being done for performance reasons. Before
committing this test change, I wanted to confirm that we don't want to
modify the actual prod code the way he does in [1].
- Melanie
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tomas Vondra | 2026-03-31 18:27:21 | Re: Add pg_stat_vfdcache view for VFD cache statistics |
| Previous Message | Alvaro Herrera | 2026-03-31 18:23:57 | Re: Adding REPACK [concurrently] |