Re: TAP test to cover "EndOfLogTLI != replayTLI" case

From: Amul Sul <sulamul(at)gmail(dot)com>
To: Julien Rouhaud <rjuju123(at)gmail(dot)com>
Cc: Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: TAP test to cover "EndOfLogTLI != replayTLI" case
Date: 2022-01-17 11:37:48
Message-ID: CAAJ_b97G9tErQ5CdpDAOeER-eNVW2M2tofYKhyDv1d-9f5w2jQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sat, Jan 15, 2022 at 11:35 AM Julien Rouhaud <rjuju123(at)gmail(dot)com> wrote:
>
> Hi,
>
> On Mon, Jan 10, 2022 at 09:46:23AM +0530, Amul Sul wrote:
> >
> > Thanks for the note, I can see the same test is failing on my centos
> > vm too with the latest master head(376ce3e404b). The failing reason is
> > the "recovery_target_inclusive = off" setting which is unnecessary for
> > this test, the attached patch removing the same.
>
> This version still fails on windows according to the cfbot:
>
> https://cirrus-ci.com/task/5882621321281536
>
> [18:14:02.639] c:\cirrus>call perl src/tools/msvc/vcregress.pl recoverycheck
> [18:14:56.114]
> [18:14:56.122] # Failed test 'check standby content before timeline switch 0/500FB30'
> [18:14:56.122] # at t/003_recovery_targets.pl line 234.
> [18:14:56.122] # got: '6000'
> [18:14:56.122] # expected: '7000'
>
> I'm switching the cf entry to Waiting on Author.

Thanks for the note.

I am not sure what really went wrong but I think the 'standby_9'
server shutdown too early before it gets a chance to archive a
required WAL file. The attached patch tries to shutdown that server
after the required WAL are archived, unfortunately, I couldn't test
that on the window, let see how cfbot reacts to this version.

Regards,
Amul

Attachment Content-Type Size
v3-0001-TAP-test-for-EndOfLogTLI.patch application/x-patch 3.4 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Langote 2022-01-17 11:40:54 Re: a misbehavior of partition row movement (?)
Previous Message Arne Roland 2022-01-17 11:25:01 Re: missing indexes in indexlist with partitioned tables