From: | Amul Sul <sulamul(at)gmail(dot)com> |
---|---|
To: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> |
Cc: | Prabhat Sahu <prabhat(dot)sahu(at)enterprisedb(dot)com>, Ibrar Ahmed <ibrar(dot)ahmad(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: [Patch] ALTER SYSTEM READ ONLY |
Date: | 2021-04-07 07:08:23 |
Message-ID: | CAAJ_b94vzYp5u6yuTjYqhF1ZZfNNxdV_o-mEvSqQsdeEnY0RRw@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Rotten again, attached the rebased version.
Regards,
Amul
On Mon, Apr 5, 2021 at 5:27 PM Amul Sul <sulamul(at)gmail(dot)com> wrote:
>
> On Mon, Apr 5, 2021 at 4:45 PM Bharath Rupireddy
> <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> wrote:
> >
>
> Thanks Bharath for your review.
>
> > On Mon, Apr 5, 2021 at 11:02 AM Amul Sul <sulamul(at)gmail(dot)com> wrote:
> > >
> > > Attached is the rebase version for the latest master head(commit # 9f6f1f9b8e6).
> >
> > Some minor comments on 0001:
> > Isn't it "might not be running"?
> > + errdetail("Checkpointer might not running."),
> >
>
> Ok, fixed in the attached version.
>
> > Isn't it "Try again after sometime"?
> > + errhint("Try after sometime again.")));
> >
>
> Ok, done.
>
> > Can we have ereport(DEBUG1 just to be consistent(although it doesn't
> > make any difference from elog(DEBUG1) with the new log messages
> > introduced in the patch?
> > + elog(DEBUG1, "waiting for backends to adopt requested WAL
> > prohibit state change");
> >
>
> I think it's fine; many existing places have used elog(DEBUG1, ....) too.
>
> Regards,
> Amul
Attachment | Content-Type | Size |
---|---|---|
v25-0001-Implement-wal-prohibit-state-using-global-barrie.patch | application/octet-stream | 52.5 KB |
v25-0003-Documentation.patch | application/octet-stream | 10.3 KB |
v25-0002-Error-or-Assert-before-START_CRIT_SECTION-for-WA.patch | application/octet-stream | 69.7 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Robins Tharakan | 2021-04-07 07:30:39 | Re: buildfarm instance bichir stuck |
Previous Message | tanghy.fnst@fujitsu.com | 2021-04-07 06:56:15 | Truncate in synchronous logical replication failed |