Rebased again.
On Wed, Apr 7, 2021 at 12:38 PM Amul Sul <sulamul(at)gmail(dot)com> wrote:
>
> Rotten again, attached the rebased version.
>
> Regards,
> Amul
>
> On Mon, Apr 5, 2021 at 5:27 PM Amul Sul <sulamul(at)gmail(dot)com> wrote:
> >
> > On Mon, Apr 5, 2021 at 4:45 PM Bharath Rupireddy
> > <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> wrote:
> > >
> >
> > Thanks Bharath for your review.
> >
> > > On Mon, Apr 5, 2021 at 11:02 AM Amul Sul <sulamul(at)gmail(dot)com> wrote:
> > > >
> > > > Attached is the rebase version for the latest master head(commit # 9f6f1f9b8e6).
> > >
> > > Some minor comments on 0001:
> > > Isn't it "might not be running"?
> > > + errdetail("Checkpointer might not running."),
> > >
> >
> > Ok, fixed in the attached version.
> >
> > > Isn't it "Try again after sometime"?
> > > + errhint("Try after sometime again.")));
> > >
> >
> > Ok, done.
> >
> > > Can we have ereport(DEBUG1 just to be consistent(although it doesn't
> > > make any difference from elog(DEBUG1) with the new log messages
> > > introduced in the patch?
> > > + elog(DEBUG1, "waiting for backends to adopt requested WAL
> > > prohibit state change");
> > >
> >
> > I think it's fine; many existing places have used elog(DEBUG1, ....) too.
> >
> > Regards,
> > Amul