| From: | Harrison Booth <harrisontbooth(at)gmail(dot)com> |
|---|---|
| To: | Bryan Green <dbryan(dot)green(at)gmail(dot)com> |
| Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: [PATCH] Fix socket handle inheritance on Windows |
| Date: | 2026-10-21 13:22:53 |
| Message-ID: | CAAH-eSUyAgD3EXXugptBT-NhOVV4HPp_PX0umRvGQtKKzZZ+mw@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Bryan,
I've attached your public patch with no changes. Also attached is a
test-only regression supplement.
On PostgreSQL master 6b9f40d49ae33eb0b4a7c77666fe4971ef7ba087, the
exact ordered series applied with git am. The focused pg_ctl test
passed all nine assertions on hosted Windows x64 and ARM64. On the
unpatched baseline, only the two socket-lifetime assertions failed on
both hosts. The supplement forces a fresh initdb so the test does not
copy the temporary install cluster.
Hosted run: https://github.com/Harrison-Booth/postgresql-windows-ci/actions/runs/39594799011
This was a focused test, not a full regression run. It does not
implement the shared SOCK_CLOEXEC flag or accept4-style API discussed
in the thread. Could you review whether this test-only supplement
belongs with your patch as posted?
Best,
Harrison
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Bryan-Green-socket-original.patch | text/x-patch | 7.6 KB |
| 0002-socket-inheritance-regression-supplement.patch | text/x-patch | 14.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Harrison Booth | 2026-10-21 13:24:12 | Re: meson: pass OpenSSL/ICU include dirs to extensions |
| Previous Message | Andreas Karlsson | 2026-10-21 13:17:12 | Re: [PG19] Indexes from 18 miss rows after pg_upgrade |