Re: meson: pass OpenSSL/ICU include dirs to extensions

From: Harrison Booth <harrisontbooth(at)gmail(dot)com>
To: imamovaj22(at)gmail(dot)com
Cc: ju(dot)grigorev(at)ftdata(dot)ru, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: meson: pass OpenSSL/ICU include dirs to extensions
Date: 2026-10-21 13:24:12
Message-ID: CAAH-eSUhYb-gD09Hmdn0f=ULMio27zKdMjWyr80_9sVv-tKQWw@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Both follow-up patches are attached in order on top of your public v4.

Patch 1 handles CMake include directories returned as strings or lists
and escapes spaces in exported flags. Patch 2 keeps PostgreSQL headers
ahead of extra include paths, passes those paths to all six fallback
header checks, and exports them through PGXS and pg_config.

I applied v4 and these exact patches to PostgreSQL master
6b9f40d49ae33eb0b4a7c77666fe4971ef7ba087. On hosted Windows x64 and
ARM64, the include-export cases passed with Meson 0.57.2 and 1.11.2.
All six fallback header probes and the psql header-order check passed
on both architectures. The v4 control reproduced the wrong-header
failure.

Hosted run: https://github.com/Harrison-Booth/postgresql-windows-ci/actions/runs/39595041637

Patch 2 addresses the same header-order concern as CF6056, but also
covers fallback probes and exported flags. I haven't combined or
tested both implementations together. These focused checks don't cover
a full server, installed extension, or PGXS runtime.

Could you review the attached follow-up patches, especially patch 2's
header-order approach?

Best,

Harrison

Attachment Content-Type Size
0001-Meson-handle-CMake-include-directory-lists-and-space.patch text/x-patch 1.3 KB
0002-Keep-external-include-flags-after-PostgreSQL-headers.patch text/x-patch 6.9 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message jian he 2026-10-21 13:33:12 Re: Row pattern recognition
Previous Message Harrison Booth 2026-10-21 13:22:53 Re: [PATCH] Fix socket handle inheritance on Windows