Re: Support logical replication of DDLs

From: Zheng Li <zhengli10(at)gmail(dot)com>
To: Peter Smith <smithpb2250(at)gmail(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>
Cc: li jie <ggysxcq(at)gmail(dot)com>, Ajin Cherian <itsajin(at)gmail(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, "houzj(dot)fnst(at)fujitsu(dot)com" <houzj(dot)fnst(at)fujitsu(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Japin Li <japinli(at)hotmail(dot)com>, rajesh singarapu <rajesh(dot)rs0541(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Support logical replication of DDLs
Date: 2023-01-07 15:28:11
Message-ID: CAAD30U+fqaaD6533-eiaWVHpUaBNBCEvqyXOT_ow1B--Aa_jOQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-general pgsql-hackers

Hi,

I added documentation and changed user interface design in the
attached v60 patch set.
The patch set addressed comments from Peter in [1].

The motivation for the user interface change is that we want to manage
DDL replication feature in stages with fine grained replication
levels.
For example, we can focus on reviewing and testing table commands
first, then other commands. It also make sense to introduce different
DDL replication levels
from the user perspective as pointed out in [1]. We can add more
replication levels along the way.

In this patch DDL replication is disabled by default and it can be
enabled at different levels
using the new PUBLICATION option 'ddl'. This option currently has two
levels and are
only allowed to be set if the PUBLICATION is FOR ALL TABLES.

all: this option enables replication of all supported DDL commands.
table: this option enables replication of Table DDL commands which include:
-CREATE/ALTER/DROP TABLE
-CREATE TABLE AS

Example:
Create a new publication with all ddl replication enabled:
CREATE PUBLICATION pub1 FOR ALL TABLES with (ddl = 'all');

Enable table ddl replication for an existing Publication:
ALTER PUBLICATION pub2 SET (ddl = 'table');

Also I break down ddl_deparse.c into two patches:
1.v60-0002-Functions-to-deparse-Table-DDL-commands.patch
2.v60-0003-Support-DDL-deparse-of-the-rest-commands.patch

Regards,
Zane

[1] https://www.postgresql.org/message-id/CAAD30UKX%3DPbojrjU0webYy7Y9mz1HmDTM3dx_JJXpc%2BdXW-EQQ%40mail.gmail.com

Attachment Content-Type Size
v60-0004-Introduce-the-test_ddl_deparse_regress-test-module.patch application/octet-stream 47.4 KB
v60-0001-Infrastructure-to-support-DDL-deparsing.patch application/octet-stream 32.6 KB
v60-0002-Functions-to-deparse-Table-DDL-commands.patch application/octet-stream 130.5 KB
v60-0005-DDL-messaging-infrastructure-for-DDL-replication.patch application/octet-stream 41.5 KB
v60-0003-Support-DDL-deparse-of-the-rest-commands.patch application/octet-stream 189.4 KB
v60-0007-Document-DDL-replication-and-DDL-deparser.patch application/octet-stream 40.6 KB
v60-0006-Support-DDL-replication.patch application/octet-stream 198.0 KB

In response to

Responses

Browse pgsql-general by date

  From Date Subject
Next Message Peter J. Holzer 2023-01-07 17:23:44 Re: Purging few months old data and vacuuming in production
Previous Message Ron 2023-01-07 13:40:01 Re: Purging few months old data and vacuuming in production

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2023-01-07 15:29:49 Re: [PATCH] Add function to_oct
Previous Message Tom Lane 2023-01-07 15:20:10 Re: postgres_fdw: using TABLESAMPLE to collect remote sample