Re: Row pattern recognition

From: Henson Choi <assam258(at)gmail(dot)com>
To: Tatsuo Ishii <ishii(at)postgresql(dot)org>
Cc: jacob(dot)champion(at)enterprisedb(dot)com, david(dot)g(dot)johnston(at)gmail(dot)com, vik(at)postgresfriends(dot)org, er(at)xs4all(dot)nl, peter(at)eisentraut(dot)org, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Row pattern recognition
Date: 2026-02-03 08:40:01
Message-ID: CAAAe_zDtstKUcKsH3FJuKeZ=ykXFWKO1Lz80JXEn9y8BeQeYNQ@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi Tatsuo,

I found a small typo in a function comment: non-ASCII letter was
> used. In my understanding, using non-ASCII letters in the program
> files are not recommended. Patch attached.
>

Thank you for catching this! You are absolutely right. I apologize for
using non-ASCII characters in the code comments.

I've reviewed all the RPR-related files and found additional instances
of non-ASCII characters:
- Arrows "→" instead of "->"
- Superscript "²" instead of "^2"
- Greater-than-or-equal "≥" instead of ">="

Found in:
- src/backend/optimizer/plan/rpr.c (1 instance)
- src/backend/executor/nodeWindowAgg.c (5 instances)
- src/include/nodes/execnodes.h (4 instances)
- src/test/regress/sql/rpr.sql (7 instances)
- src/test/regress/sql/rpr_base.sql (15 instances)
- src/test/regress/expected/rpr.out (7 instances)
- src/test/regress/expected/rpr_base.out (15 instances)

Total: 54 instances across 7 files.

To ensure comprehensive coverage, I created a Python verification tool
that checks for non-ASCII characters and reports their Unicode code
points. I've verified all 46 files changed in the v42 patch series,
and confirmed no additional non-ASCII characters remain.

I'll be more careful going forward to use only ASCII characters in
source files and comments. Updated patch attached.

Best regards,
Henson

Attachment Content-Type Size
Fix-non-ASCII-characters.txt text/plain 13.5 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Pierre Ducroquet 2026-02-03 08:42:33 Re: Change default of jit to off
Previous Message Corey Huinker 2026-02-03 08:27:53 Re: Add expressions to pg_restore_extended_stats()