Re: Row pattern recognition

From: Henson Choi <assam258(at)gmail(dot)com>
To: Tatsuo Ishii <ishii(at)postgresql(dot)org>
Cc: jian(dot)universality(at)gmail(dot)com, zsolt(dot)parragi(at)percona(dot)com, sjjang112233(at)gmail(dot)com, vik(at)postgresfriends(dot)org, er(at)xs4all(dot)nl, jacob(dot)champion(at)enterprisedb(dot)com, david(dot)g(dot)johnston(at)gmail(dot)com, peter(at)eisentraut(dot)org, li(dot)evan(dot)chao(at)gmail(dot)com, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Row pattern recognition
Date: 2026-09-08 06:31:42
Message-ID: CAAAe_zApT2qLmQ88c-xBcrsF5Q6+3_RgaNAbcEe7Z_Nz=mmwzg@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi Tatsuo,

> So my plan for v52 is, using PG_USED_FOR_ASSERTS_ONLY
> for "pattern" as below. Does this work for you?

Yes, I think that works.

Another way is to have the Assert read winstate->rpPattern in place
of the local:

Assert(elem->next >= 0 &&
elem->next < winstate->rpPattern->numElements);

Either is fine. 2013 in the increment removes the local, so the two
end up at the same place.

Best regards,
Henson

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Grigorev Jurij 2026-09-08 06:34:29 Re: Missing dshash cleanup in pgstat_read_statsfile() after OOM
Previous Message Kirill Reshke 2026-09-08 06:26:50 Re: Use WALReadFromBuffers in more places