Re: [DEPARSE] AT TIME ZONE and similar as a function in FROM do not read back

From: Henson Choi <assam258(at)gmail(dot)com>
To: Prashant Kumar <crprashant(at)hotmail(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [DEPARSE] AT TIME ZONE and similar as a function in FROM do not read back
Date: 2026-10-23 05:10:39
Message-ID: CAAAe_zDB=PpDxLVR2HefqXUOySgHL6j6WPf_zSoaw7z3-gzbwg@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi Prashant,

> One suggestion: the tests added to tt20v cover the timestamp and
> timestamptz forms, but not the timetz form of AT TIME ZONE, which
> is broken in the same way and fixed by the same list.

Thank you for the careful review and testing. As you suggest, I
will send a revised patch (v2) to the thread with the tests
extended by the timetz form of AT TIME ZONE in tt20v.

So that you can also exchange reviews by mail, here is how. A
review in the CommitFest app is fine, but replying by mail lets the
discussion continue right in the thread.

1. Log in to https://lists.postgresql.org/ with the same
community account you use for the CommitFest app and subscribe
to pgsql-hackers. The list has a lot of traffic, so in Gmail I
made a label: list mail skips the inbox and goes straight to
that label, and only mail with my address in To or Cc stays in
the inbox. An AI agent will also work out such a filter in
detail if you ask.

2. To reply to a message sent before you subscribed, open the
patch page in the CommitFest app
(e.g. https://commitfest.postgresql.org/patch/7491/) and click
the thread title or the "Latest at" date under Emails to go to
that message in the mail archive. While logged in, click
"Resend email"; it is sent to your inbox again. "Reply all" to
that mail keeps the thread together.

3. When replying, put the person the message is meant for in To, if
there is one, and the people who took part in the thread, along
with pgsql-hackers, in Cc. Write in plain text and, by convention,
break lines yourself so that none goes past 80 columns (around 72
is common). The convention for replies is inline replies: keep
only the sentences you answer as quotes, delete the rest, and
write your answer right below each quote (no top-posting).

One more thing: the AI agent you already use can explain this
PostgreSQL contribution process, such as mailing-list conventions
and how the CommitFest works, quite well.

Regards,
Henson

In response to

Browse pgsql-hackers by date

  From Date Subject
Previous Message Manu 2026-10-23 05:05:55 Re: [PG19] Promotion hangs behind a backend blocked on a stuck client