Re: [PATCH] few fts functions for jsonb

From: Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com>
To: Dmitry Dolgov <9erthalion6(at)gmail(dot)com>
Cc: Oleg Bartunov <obartunov(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] few fts functions for jsonb
Date: 2017-03-30 22:01:39
Message-ID: CAA8=A785XTOUkedF6j+fX7GPW4qXBr7D3_YV6Ge2tVpq5r4LkA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 29 March 2017 at 16:19, Dmitry Dolgov <9erthalion6(at)gmail(dot)com> wrote:
>> On 29 March 2017 at 18:28, Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com>
>> wrote:
>>
>> These patches seem fundamentally OK. But I'm still not happy with the
>> naming etc.
>
> I've changed names for all functions and action definitions, moved out the
> changes in header file to `jsonapi.h` and removed `is_jsonb_data` macro. So
> it
> should be better now.

I have just noticed as I was writing/testing the non-existent docs for
this patch that it doesn't supply variants of to_tsvector that take a
regconfig as the first argument. Is there a reason for that? Why
should the json(b) versions be different from the text versions?

cheers

andrew

--
Andrew Dunstan https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2017-03-30 22:16:57 End of CommitFest + Feature Freeze Delayed To April 7th
Previous Message Erik Rijkers 2017-03-30 21:44:22 Re: Logical replication existing data copy