Re: Rename LWLockNewTrancheId() parameter from "name" to "tranche_name"

From: Sami Imseih <samimseih(at)gmail(dot)com>
To: Nathan Bossart <nathandbossart(at)gmail(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Rename LWLockNewTrancheId() parameter from "name" to "tranche_name"
Date: 2026-03-26 19:33:52
Message-ID: CAA5RZ0uJ15COoA5xxvVcMH_WKqozc=ozH_JYuyO6PJjvLyCJ0g@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> > While looking at something nearby, I noticed a naming inconsistency for
> > the parameter name in LWLockNewTrancheId(). It should be tranche_name,
> > similar to RequestNamedLWLockTranche(), and in other places it's
> > referenced in the docs/comments.
>
> I don't mind changing it, but I don't find "tranche_name" to be
> substantially better than "name" in this case.

It's just a matter of consistency and it's more descriptive to the
caller, IMO.

--
Sami Imseih
Amazon Web Services (AWS)

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Antonin Houska 2026-03-26 19:36:45 Re: Adding REPACK [concurrently]
Previous Message Nathan Bossart 2026-03-26 19:30:37 Re: Rename LWLockNewTrancheId() parameter from "name" to "tranche_name"