| From: | Sami Imseih <samimseih(at)gmail(dot)com> |
|---|---|
| To: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
| Cc: | Florents Tselai <florents(dot)tselai(at)gmail(dot)com>, Rahila Syed <rahilasyed90(at)gmail(dot)com>, Dagfinn Ilmari Mannsåker <ilmari(at)ilmari(dot)org>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: add function for creating/attaching hash table in DSM registry |
| Date: | 2025-06-11 22:15:36 |
| Message-ID: | CAA5RZ0tzabjrJT=kDSKcC33iMYPo1DuaKuJYK5BDWXzFbBj_eA@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
I tested v6 and I think GetNamedDSA is a good addition. I did
not find any issues with the code. However, I am still convinced
that GetNamedDSMHash should not append " Hash" to the tranche
name of the dshash [0]. I am ok with " DSA" because the DSA tranche
is created implicitly by the API.
Also, with GetNamedDSA not appending any suffixes, it will be
strange to have some extensions that use both GetNamedDSA
and GetNamedDSMHash finding that one API appends a suffix
and the other does not. but, maybe that's only my view.
--
Sami
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2025-06-11 22:16:37 | Re: Replace some %llu remnants in the tree |
| Previous Message | Peter Geoghegan | 2025-06-11 22:09:55 | Re: Adding skip scan (including MDAM style range skip scan) to nbtree |