| From: | Sami Imseih <samimseih(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Mircea Cadariu <cadariu(dot)mircea(at)gmail(dot)com>, Frédéric Yhuel <frederic(dot)yhuel(at)dalibo(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Benoit Lobréau <benoit(dot)lobreau(at)dalibo(dot)com>, Guillaume Lelarge <guillaume(dot)lelarge(at)dalibo(dot)com>, Pierrick Chovelon <pierrick(dot)chovelon(at)dalibo(dot)com> |
| Subject: | Re: [BUG] temporary file usage report with extended protocol and unnamed portals |
| Date: | 2025-09-16 19:13:39 |
| Message-ID: | CAA5RZ0t==BMNxjg+aDT+5oSUKMb1ApLdv-jKWWNfZceHdbDwrA@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> Just my 2c while looking at this particular part of the thread. Now
> to the main patch proposed, v8 or v10..
I have been thinking about whether test coverage is worth it for temp
file logging. I think it is, but others may disagree. However, I also
don't think the current tests are correct.
For example, this is not true. We should now always log the correct query.
```
ok(0, "The wrong query has been logged");
```
Also, the tests should be checking that we are logging "temporary file: "
before the next statement is logged.
I split up the actual fix and the corrected tests into separate patches.
They can be committed together if there is agreement that tests are worth it.
--
Sami
| Attachment | Content-Type | Size |
|---|---|---|
| v11-0001-Fix-temp-file-log-blame-for-unnamed-portals.patch | application/octet-stream | 3.4 KB |
| v11-0002-Add-tests-for-temp-table-logging.patch | application/octet-stream | 3.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jacob Champion | 2025-09-16 19:16:58 | Re: OAuth client code doesn't work with Google OAuth |
| Previous Message | Greg Burd | 2025-09-16 19:04:39 | Re: [PATCH] Add tests for Bitmapset |