| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Sami Imseih <samimseih(at)gmail(dot)com> |
| Cc: | Mircea Cadariu <cadariu(dot)mircea(at)gmail(dot)com>, Frédéric Yhuel <frederic(dot)yhuel(at)dalibo(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Benoit Lobréau <benoit(dot)lobreau(at)dalibo(dot)com>, Guillaume Lelarge <guillaume(dot)lelarge(at)dalibo(dot)com>, Pierrick Chovelon <pierrick(dot)chovelon(at)dalibo(dot)com> |
| Subject: | Re: [BUG] temporary file usage report with extended protocol and unnamed portals |
| Date: | 2025-09-18 07:06:17 |
| Message-ID: | aMuvaYVOqH86Qzrb@paquier.xyz |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Sep 16, 2025 at 02:13:39PM -0500, Sami Imseih wrote:
> Also, the tests should be checking that we are logging "temporary file: "
> before the next statement is logged.
>
> I split up the actual fix and the corrected tests into separate patches.
> They can be committed together if there is agreement that tests are worth it.
I find the tests interesting to have, especially if we make these code
paths more complicated in terms of the statements we expect to log for
these logs when it comes to the temporary files cleaned up.
Now, if I apply patch v11-0002 that only adds the tests but not
v11-0001, the tests pass. It means that the tests as proposed do not
actually validate what 0001 changes. Shouldn't the tests with \bind
at least be able to detect the case of unnamed portals and that the
statements reports we are attaching to them become what we think is
the correct deal?
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Yugo Nagata | 2025-09-18 07:20:17 | Re: Suggestion to add --continue-client-on-abort option to pgbench |
| Previous Message | Michael Paquier | 2025-09-18 06:53:47 | Re: [BUG] temporary file usage report with extended protocol and unnamed portals |