Re: [BUG] temporary file usage report with extended protocol and unnamed portals

From: Mircea Cadariu <cadariu(dot)mircea(at)gmail(dot)com>
To: Sami Imseih <samimseih(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Frédéric Yhuel <frederic(dot)yhuel(at)dalibo(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Benoit Lobréau <benoit(dot)lobreau(at)dalibo(dot)com>, Guillaume Lelarge <guillaume(dot)lelarge(at)dalibo(dot)com>, Pierrick Chovelon <pierrick(dot)chovelon(at)dalibo(dot)com>
Subject: Re: [BUG] temporary file usage report with extended protocol and unnamed portals
Date: 2025-09-17 13:35:53
Message-ID: 075f4094-590d-4147-98e2-68d5bc692828@gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 16/09/2025 21:13, Sami Imseih wrote:
> They can be committed together if there is agreement that tests are worth it.

One argument for keeping the tests would be that they nicely bring
together the side-effect (logging) and these use-cases, whereas in the
code they're pretty distant, making the connection not obvious.

For example, they will come in handy when simplifying CreatePortal in a
separate patch as discussed.

Kind regards,

Mircea Cadariu

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Marcos Pegoraro 2025-09-17 13:36:34 Re: REPACK and naming
Previous Message Dilip Kumar 2025-09-17 13:35:32 Re: Incorrect logic in XLogNeedsFlush()