| From: | Sami Imseih <samimseih(at)gmail(dot)com> |
|---|---|
| To: | maciek(at)sakrejda(dot)org |
| Cc: | Shinya Kato <shinya11(dot)kato(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Nathan Bossart <nathandbossart(at)gmail(dot)com>, Robert Treat <rob(at)xzilla(dot)net>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Add mode column to pg_stat_progress_vacuum |
| Date: | 2025-11-20 01:34:19 |
| Message-ID: | CAA5RZ0suoicwxFeK_eDkUrzF7s0BVTaE7M+ehCpYcCk5wiECpw@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
The patch looks overall good to me. I have a few comments:
1/ I believe It is possible for the mode to flip to "failsafe" during the
operation since lazy_check_wraparound_failsafe() is checked in-flight.
I think this should be mentioned in the "mode" section of the documentation
in the "failsafe" description.
2/ It feels odd that we do not have parity of the "mode" column in
pg_stat_progress_analyze. Should we add a "mode" column
there also that shows if the analyze was triggered_by "manual" or
"autovacuum"? An autovacuum in a relation can trigger both
a vacuum and an analyze, and a VACUUM(ANALYZE) will
also do both.
--
Sami Imseih
Amazon Web Services (AWS)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Japin Li | 2025-11-20 01:39:36 | Re: [PATCH] Add pg_get_database_ddl() function to reconstruct CREATE DATABASE statement |
| Previous Message | Andreas Karlsson | 2025-11-20 01:29:16 | Re: ON CONFLICT DO SELECT (take 3) |