| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Ashutosh Bapat <ashutosh(dot)bapat(at)enterprisedb(dot)com> |
| Subject: | Re: Diagnostic comment in LogicalIncreaseXminForSlot |
| Date: | 2021-05-21 05:56:34 |
| Message-ID: | CAA4eK1LwSmJdtKVSBNhP9to_oxMyVYnUKv8g9o6Eb6DPAd4Zgw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, May 20, 2021 at 5:43 PM Ashutosh Bapat
<ashutosh(dot)bapat(dot)oss(at)gmail(dot)com> wrote:
>
> Hi
> LogicalIncreaseRestartDecodingForSlot() has a debug log to report a
> new restart_lsn. But the corresponding function for catalog_xmin.
> Here's a patch to add the same.
>
I think this can be useful. One minor comment:
+ elog(DEBUG1, "got new catalog_xmin %u at %X/%X", xmin,
+ (uint32) (current_lsn >> 32), (uint32) current_lsn);
Isn't it better to use LSN_FORMAT_ARGS for current_lsn? Also, there
doesn't seem to be any urgency for adding this, so you can register it
for the next CF so that we can add this when the branch opens for
PG-15.
--
With Regards,
Amit Kapila.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2021-05-21 06:32:05 | Re: Move pg_attribute.attcompression to earlier in struct for reduced size? |
| Previous Message | Bharath Rupireddy | 2021-05-21 05:41:40 | Re: Fdw batch insert error out when set batch_size > 65535 |