Re: Proposal: Make use of C99 designated initialisers for nulls/values arrays

From: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
To: "Smith, Peter" <peters(at)fast(dot)au(dot)fujitsu(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Proposal: Make use of C99 designated initialisers for nulls/values arrays
Date: 2019-10-01 10:12:08
Message-ID: CAA4eK1Lszqs6h=TdnUvYRycS=z4ZMSSbtf5w81xBevGuk1BdmA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Oct 1, 2019 at 1:25 PM Smith, Peter <peters(at)fast(dot)au(dot)fujitsu(dot)com> wrote:
>
> Dear Hackers,
>
> I have identified some OSS code which maybe can make use of C99 designated initialisers for nulls/values arrays.
>
> ~
>
> Background:
> There are lots of tuple operations where arrays of values and flags are being passed.
> Typically these arrays are being previously initialised 0/false by memset.
> By modifying code to use C99 designated initialiser syntax [1], most of these memsets can become redundant.
> Actually, this mechanism is already being used in some of the existing OSS code. This patch/proposal just propagates the same idea to all other similar places I could find.
>
> ~
>
> Result:
> Less code. Removes ~200 unnecessary memsets.
> More consistent initialisation.
>

+1. This seems like an improvement. I can review and take this
forward unless there are objections from others.

--
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Kyotaro Horiguchi 2019-10-01 10:32:08 Re: Change atoi to strtol in same place
Previous Message Tomas Vondra 2019-10-01 10:08:05 Re: Optimize partial TOAST decompression