| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | Ashutosh Bapat <ashutosh(dot)bapat(at)enterprisedb(dot)com> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Thinko/typo in ExecSimpleRelationInsert |
| Date: | 2018-06-26 12:48:21 |
| Message-ID: | CAA4eK1LiezdBTGxspbhba=yXY_yWV=6ezj5FQ0zGGa8hvDGjHA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Jun 26, 2018 at 4:33 PM, Ashutosh Bapat
<ashutosh(dot)bapat(at)enterprisedb(dot)com> wrote:
> Looks like we need similar adjustment in ExecSimpleRelationUpdate() as
> well. Updated the patch.
>
- /* Store the slot into tuple that we can write. */
+ /* Materialize slot into a tuple that we can inspect. */
tuple = ExecMaterializeSlot(slot);
I think it is better to keep the last word of the sentence as "write"
instead of "inspect" as was in the original sentence. It makes more
sense as we are materializing the tuple to write it. Similarly, in
the other change in the patch can use "write".
--
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Arthur Zakirov | 2018-06-26 13:04:47 | Re: [PROPOSAL] Nepali Snowball dictionary |
| Previous Message | Alexander Korotkov | 2018-06-26 12:42:08 | Re: [HACKERS] GUC for cleanup indexes threshold. |