| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
| Cc: | Ajin Cherian <itsajin(at)gmail(dot)com>, Petr Jelinek <petr(dot)jelinek(at)enterprisedb(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Single transaction in the tablesync worker? |
| Date: | 2021-02-25 04:52:41 |
| Message-ID: | CAA4eK1LbYMBn2iE77huSMU6+iUaHWapSt4g5HPY+9XQ2Z1EhGQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Feb 24, 2021 at 5:55 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>
> On Wed, Feb 24, 2021 at 12:47 PM Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
> >
> > On Fri, Feb 12, 2021 at 2:49 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> > >
> > >
> > > Thanks, I have pushed the fix and the latest run of 'thorntail' has passed.
> >
> > I got the following WARNING message from a logical replication apply worker:
> >
> > WARNING: relcache reference leak: relation "pg_subscription_rel" not closed
> >
> > The cause of this is that GetSubscriptionRelState() doesn't close the
> > relation in SUBREL_STATE_UNKNOWN case. It seems that commit ce0fdbfe9
> > forgot to close it. I've attached the patch to fix this issue.
> >
>
> Thanks for the report and fix. Your patch LGTM. I'll push it tomorrow.
>
Pushed!
--
With Regards,
Amit Kapila.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Geoghegan | 2021-02-25 05:21:54 | Re: 64-bit XIDs in deleted nbtree pages |
| Previous Message | Peter Geoghegan | 2021-02-25 04:42:15 | Re: 64-bit XIDs in deleted nbtree pages |