| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
| Cc: | Ajin Cherian <itsajin(at)gmail(dot)com>, Petr Jelinek <petr(dot)jelinek(at)enterprisedb(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Single transaction in the tablesync worker? |
| Date: | 2021-02-24 12:25:54 |
| Message-ID: | CAA4eK1LZHhEtWe-YrRgb4_i3NQhcCwO9p3n1w-E0WwZdTcWTYA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Feb 24, 2021 at 12:47 PM Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
>
> On Fri, Feb 12, 2021 at 2:49 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> >
> >
> > Thanks, I have pushed the fix and the latest run of 'thorntail' has passed.
>
> I got the following WARNING message from a logical replication apply worker:
>
> WARNING: relcache reference leak: relation "pg_subscription_rel" not closed
>
> The cause of this is that GetSubscriptionRelState() doesn't close the
> relation in SUBREL_STATE_UNKNOWN case. It seems that commit ce0fdbfe9
> forgot to close it. I've attached the patch to fix this issue.
>
Thanks for the report and fix. Your patch LGTM. I'll push it tomorrow.
--
With Regards,
Amit Kapila.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Greg Nancarrow | 2021-02-24 12:51:26 | Re: Parallel INSERT (INTO ... SELECT ...) |
| Previous Message | Daniel Gustafsson | 2021-02-24 12:23:32 | Re: Support for NSS as a libpq TLS backend |