| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | Zhijie Hou <houzhijie22(at)gmail(dot)com> |
| Cc: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Assertion failure in update_local_synced_slot(), slotsync.c:364 |
| Date: | 2026-11-19 13:49:21 |
| Message-ID: | CAA4eK1LOLbpqri7KdffMQVDMPDSyCs=UG0UoCt0V6y2_fSuZ=w@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Nov 18, 2026 at 6:01 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>
> *
> @@ -335,10 +345,10 @@ update_local_synced_slot(RemoteSlot
> *remote_slot, Oid remote_dbid)
> SpinLockRelease(&slot->mutex);
>
> updated_xmin_or_lsn = true;
> + found_consistent_snapshot = true;
> }
> This change makes me wonder whether found_consistent_point is a good
> name for this variable as in this loop, we didn’t find anything. How
> about consistent_snapshot_available or has_consistent_snapshot? I have
> used the earlier in the attached and slightly changed the comments.
>
Pushed.
--
With Regards,
Amit Kapila.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Sami Imseih | 2026-11-19 13:55:40 | Re: Avoid redundant BitmapAnd with a clauseless partial index |
| Previous Message | Amit Langote | 2026-11-19 13:40:08 | Re: [PATCH]Fix planner's strictness check for JsonExpr |