| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | Zhijie Hou <houzhijie22(at)gmail(dot)com> |
| Cc: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Assertion failure in update_local_synced_slot(), slotsync.c:364 |
| Date: | 2026-11-18 12:31:53 |
| Message-ID: | CAA4eK1+N7mm7yen-v_-ig6i0+yU79WnhOSqjrr3EMWL-hM+h1w@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Nov 16, 2026 at 1:39 PM Zhijie Hou <houzhijie22(at)gmail(dot)com> wrote:
>
> Attached is the v3 patch set (with the TAP test split into 0002). Please
> let me know what you think.
>
*
@@ -335,10 +345,10 @@ update_local_synced_slot(RemoteSlot
*remote_slot, Oid remote_dbid)
SpinLockRelease(&slot->mutex);
updated_xmin_or_lsn = true;
+ found_consistent_snapshot = true;
}
This change makes me wonder whether found_consistent_point is a good
name for this variable as in this loop, we didn’t find anything. How
about consistent_snapshot_available or has_consistent_snapshot? I have
used the earlier in the attached and slightly changed the comments.
--
With Regards,
Amit Kapila.
| Attachment | Content-Type | Size |
|---|---|---|
| v4-0001-Fix-premature-persistence-of-synced-slots-without.patch | application/octet-stream | 6.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Álvaro Herrera | 2026-11-18 12:48:38 | Re: [PATCH] psql: Fix REPACK index completion after a column list |
| Previous Message | Nazir Bilal Yavuz | 2026-11-18 12:15:45 | Re: Fix ReadStream handling when heap rescan strategy changes |