Re: Logical WAL sender unresponsive during decoding commit

From: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
To: Andrey Borodin <x4mmm(at)yandex-team(dot)ru>
Cc: PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Logical WAL sender unresponsive during decoding commit
Date: 2022-08-16 05:08:05
Message-ID: CAA4eK1LLOTEF4KT8H5Sxg+A1su1c_OqEZLUbUZVyPP0b-g153w@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Aug 16, 2022 at 9:28 AM Andrey Borodin <x4mmm(at)yandex-team(dot)ru> wrote:
>
> Hi hackers!
>
> Some time ago I've seen a hanging logical replication that was trying to send transaction commit after doing table pg_repack.
> I understand that those things do not mix well. Yet walsender was ignoring pg_terminate_backend() and I think this worth fixing.
> Can we add CHECK_FOR_INTERRUPTS(); somewhere in this backtrace?
>

I think if we want to do this in this code path then it may be it is
better to add it in ReorderBufferProcessTXN where we are looping to
process each change.

--
With Regards,
Amit Kapila.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2022-08-16 05:14:47 Re: pg_upgrade test writes to source directory
Previous Message Amit Kapila 2022-08-16 05:02:23 Re: Support logical replication of global object commands