| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com> |
| Cc: | "shiy(dot)fnst(at)fujitsu(dot)com" <shiy(dot)fnst(at)fujitsu(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com>, Melih Mutlu <m(dot)melihmutlu(at)gmail(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, Euler Taveira <euler(at)eulerto(dot)com>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, "Takamichi Osumi (Fujitsu)" <osumi(dot)takamichi(at)fujitsu(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Allow logical replication to copy tables in binary format |
| Date: | 2023-03-23 05:48:19 |
| Message-ID: | CAA4eK1LKoaAOzYdthH8Sg3eRYi+t39esqXH_Sc7O8YLtWfKamg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Mar 22, 2023 at 4:06 PM Hayato Kuroda (Fujitsu)
<kuroda(dot)hayato(at)fujitsu(dot)com> wrote:
>
> > The patch looks mostly good to me. However, I have one
> > question/comment as follows:
> >
> > - <varlistentry>
> > + <varlistentry id="sql-createsubscription-binary" xreflabel="binary">
> > <term><literal>binary</literal> (<type>boolean</type>)</term>
> > <listitem>
> >
> > To allow references to the binary option, we add the varlistentry id
> > here. It looks slightly odd to me to add id for just one entry, see
> > commit 78ee60ed84bb3a1cf0b6bd9a715dcbcf252a90f5 where we have
> > purposefully added ids to allow future references. Shall we add id to
> > other options as well on this page?
>
> I have analyzed same points and made patch that could be applied atop v19-0001.
> Please check 0002 patch.
>
Pushed the 0001. It may be better to start a separate thread for 0002.
--
With Regards,
Amit Kapila.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Himanshu Upadhyaya | 2023-03-23 05:50:04 | Re: HOT chain validation in verify_heapam() |
| Previous Message | Corey Huinker | 2023-03-23 05:38:42 | Re: Add n_tup_newpage_upd to pg_stat table views |