| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, pgsql-committers <pgsql-committers(at)postgresql(dot)org> |
| Subject: | Re: pgsql: hash: Add write-ahead logging support. |
| Date: | 2017-03-15 04:14:23 |
| Message-ID: | CAA4eK1L8v8peBmG7NRJk4GP=L6tG4ycGPPDwt_a4kBLq=GB5og@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
On Wed, Mar 15, 2017 at 9:18 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> writes:
>> On Wed, Mar 15, 2017 at 8:56 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>>> However, we probably do need to fix the src/test/mb/expected/ files.
>>> Has anyone tried running that test suite?
>
>> I haven't tried. Does this run as part of any regression tests or is
>> the only way is run it manually (sh mbregress.sh)?
>
> I don't believe it's connected up to any top-level test target ---
> if it were, the buildfarm would likely have noticed this.
>
I also think so. In any case, I have run those now and they are
failing as expected. I will send a patch to fix these tests.
--
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2017-03-15 05:49:42 | Re: pgsql: hash: Add write-ahead logging support. |
| Previous Message | Peter Eisentraut | 2017-03-15 03:59:52 | pgsql: Allow referring to functions without arguments when unique |