Re: pgsql: hash: Add write-ahead logging support.

On Wed, Mar 15, 2017 at 9:44 AM, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> On Wed, Mar 15, 2017 at 9:18 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> writes:
>>> On Wed, Mar 15, 2017 at 8:56 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>>>> However, we probably do need to fix the src/test/mb/expected/ files.
>>>> Has anyone tried running that test suite?
>>
>>> I haven't tried. Does this run as part of any regression tests or is
>>> the only way is run it manually (sh mbregress.sh)?
>>
>> I don't believe it's connected up to any top-level test target ---
>> if it were, the buildfarm would likely have noticed this.
>>
>
> I also think so. In any case, I have run those now and they are
> failing as expected. I will send a patch to fix these tests.
>

Attached are two patches, one to fix multi-byte regression tests and
another is spurious function reference in one of the comments in hash
index code.

--
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com