Re: rename SnapBuild* macros in slot.c

From: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
To: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
Cc: Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: rename SnapBuild* macros in slot.c
Date: 2021-11-23 02:42:18
Message-ID: CAA4eK1L8UTokKAeB1=OrvFdfX9S_z0Kn45xrTALGqqoz5WZhqw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Nov 22, 2021 at 7:47 PM Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> wrote:
>
> On 2021-Nov-22, Amit Kapila wrote:
>
> > +1 for this change. This seems to be introduced by commit ec5896aed3
> > [1] and I think it is just a typo to name these macros starting with
> > SnapBuildOnDisk* unless I am missing something.
>
> Yeah, it looks pretty weird. +1 for the change on consistency grounds.
>

Okay, I will push this tomorrow unless I see any objections.

--
With Regards,
Amit Kapila.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Kapila 2021-11-23 03:20:57 Re: pg_get_publication_tables() output duplicate relid
Previous Message houzj.fnst@fujitsu.com 2021-11-23 01:58:05 RE: pg_get_publication_tables() output duplicate relid