Re: rename SnapBuild* macros in slot.c

From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
Cc: Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: rename SnapBuild* macros in slot.c
Date: 2021-11-22 14:17:35
Message-ID: 202111221417.ezsl5icqowhh@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2021-Nov-22, Amit Kapila wrote:

> +1 for this change. This seems to be introduced by commit ec5896aed3
> [1] and I think it is just a typo to name these macros starting with
> SnapBuildOnDisk* unless I am missing something.

Yeah, it looks pretty weird. +1 for the change on consistency grounds.

--
Álvaro Herrera Valdivia, Chile — https://www.EnterpriseDB.com/

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2021-11-22 14:21:15 Re: Windows build warnings
Previous Message Robert Haas 2021-11-22 14:02:47 Re: Teach pg_receivewal to use lz4 compression