Re: pgsql: Add a new GUC and a reloption to enable inserts in parallel-mode

From: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Amit Kapila <akapila(at)postgresql(dot)org>, pgsql-committers <pgsql-committers(at)lists(dot)postgresql(dot)org>
Subject: Re: pgsql: Add a new GUC and a reloption to enable inserts in parallel-mode
Date: 2021-04-09 06:42:02
Message-ID: CAA4eK1L2Gm7qhX6sGLv+6UUUt+UBE6U=pSoxD9KWXFv3nUHYJA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On Fri, Mar 26, 2021 at 11:07 AM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>
> On Wed, Mar 24, 2021 at 12:14 AM Andres Freund <andres(at)anarazel(dot)de> wrote:
> >
> >
> > Shouldn't we have this in IndexOptInfo already?
> >
>
> No, because I think we don't build IndexOptInfo for target tables
> (tables in which insert is performed). It is only built for tables to
> scan. However, I think here we could cache parallel-safety info in the
> index rel descriptor and can use it for next time. This will avoid
> checking expressions each time.
>

On further investigation, it seems we can't rely on the cached
information of parallel-safety in rel descriptor because we don't
invalidate it if someone changes function property say from safe to
unsafe or vice-versa. We need to think of some other idea here, simply
caching rel descriptors won't work. I think we need to further discuss
this topic on -hackers.

--
With Regards,
Amit Kapila.

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Magnus Hagander 2021-04-09 10:41:58 pgsql: Fix typo
Previous Message Michael Paquier 2021-04-09 06:00:31 Re: pgsql: Move tablespace path re-creation from the makefiles to pg_regres