Re: Missing list_free in publicationcmds.c:OpenTableList

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
Cc: Peter Smith <smithpb2250(at)gmail(dot)com>, surya poondla <suryapoondla4(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "zhong950419(at)gmail(dot)com" <zhong950419(at)gmail(dot)com>, shveta malik <shveta(dot)malik(at)gmail(dot)com>
Subject: Re: Missing list_free in publicationcmds.c:OpenTableList
Date: 2026-08-11 12:36:36
Message-ID: 06E52B28-3702-4E4A-859D-6DE362E6E291@yesql.se
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On 11 Aug 2026, at 04:27, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>
> On Tue, Aug 11, 2026 at 4:51 AM Peter Smith <smithpb2250(at)gmail(dot)com> wrote:
>>
>> Fair enough. TBH I'm not sure if comments like this are usual
>> practice,
>
> Yes, I have a similar understanding so let's not set a precedent that
> could invite similar comments sprinkled everywhere a list_free/pfree
> is not called, which is noise rather than signal.

A very big +1 on that.

--
Daniel Gustafsson

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Jelte Fennema-Nio 2026-08-11 12:39:40 Re: CI slowdown due to PG_TEST_INITDB_EXTRA_OPTS
Previous Message Jelte Fennema-Nio 2026-08-11 12:31:06 Re: Add PQTRACE env to enable protocol tracing in libpq