| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Rushabh Lathia <rushabh(dot)lathia(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: GatherMerge misses to push target list |
| Date: | 2017-11-12 07:29:50 |
| Message-ID: | CAA4eK1KuA2Cg963BdSyOK=+XnkU47B3P_VfgdZWxNWwBOce60A@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, Nov 11, 2017 at 5:05 PM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> On Mon, Sep 18, 2017 at 7:02 AM, Rushabh Lathia
> <rushabh(dot)lathia(at)gmail(dot)com> wrote:
>>> In that case, can you please mark the patch [1] as ready for committer in
>>> CF app
>>
>> Done.
>
> I think this patch is mostly correct, but I think the change to
> planner.c isn't quite right. ordered_rel->reltarget is just a dummy
> target list that produces nothing. Instead, I think we should pass
> path->pathtarget, representing the idea that whatever Gather Merge
> produces as output is the same as what you put into it.
>
Agreed. Your change looks good to me.
--
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2017-11-12 07:51:54 | Re: A GUC to prevent leader processes from running subplans? |
| Previous Message | Pavel Stehule | 2017-11-12 04:33:55 | Re: possible encoding issues with libxml2 functions |