| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Rushabh Lathia <rushabh(dot)lathia(at)gmail(dot)com> |
| Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: GatherMerge misses to push target list |
| Date: | 2017-11-11 11:35:38 |
| Message-ID: | CA+TgmoY6ZYfmJUKwhJ1wFuFk2yXZj8OJrNHRskcMXvt_UTBNVA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Sep 18, 2017 at 7:02 AM, Rushabh Lathia
<rushabh(dot)lathia(at)gmail(dot)com> wrote:
>> In that case, can you please mark the patch [1] as ready for committer in
>> CF app
>
> Done.
I think this patch is mostly correct, but I think the change to
planner.c isn't quite right. ordered_rel->reltarget is just a dummy
target list that produces nothing. Instead, I think we should pass
path->pathtarget, representing the idea that whatever Gather Merge
produces as output is the same as what you put into it.
See attached.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| Attachment | Content-Type | Size |
|---|---|---|
| pushdown-gathermerge-tlist.patch | application/octet-stream | 5.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2017-11-11 12:19:26 | Re: [PROPOSAL] Temporal query processing with range types |
| Previous Message | Graham Leggett | 2017-11-11 10:50:16 | Re: [Patch] Log SSL certificate verification errors |